protocols/kad: Remove deprecated set_protocol_name()#2866
Merged
mxinden merged 3 commits intolibp2p:masterfrom Sep 15, 2022
Merged
protocols/kad: Remove deprecated set_protocol_name()#2866mxinden merged 3 commits intolibp2p:masterfrom
set_protocol_name()#2866mxinden merged 3 commits intolibp2p:masterfrom
Conversation
4 tasks
thomaseizinger
approved these changes
Sep 3, 2022
…rotocol-name-setters
mxinden
approved these changes
Sep 15, 2022
Member
|
Testground interop tests failing due to libp2p/test-plans#41. I am going to proceed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up PR to #2846. As discussed there, single Kademlia protocol name setters should be removed after a grace deprecation period. Must be merged only after
libp2p-kadv0.40.0is released.Change checklist